Skip to content

🔨 Switch SearchDependenciesModal to use useOvermind #3366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2020
Merged

🔨 Switch SearchDependenciesModal to use useOvermind #3366

merged 1 commit into from
Jan 27, 2020

Conversation

@MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented Jan 19, 2020

Follow-up of #2747

Things I did extra:

  • Make SearchDependenciesModal a FunctionComponent
  • Export SearchDependenciesModal by a named export instead of a default export

@MichaelDeBoey MichaelDeBoey added 🔨 Refactor 🧠 Overmind Indicates that this is related to the app's State Management labels Jan 19, 2020
@lbogdan
Copy link
Contributor

lbogdan commented Jan 19, 2020

Build for latest commit f8ec0d7 is at https://pr3366.build.csb.dev/s/new.

SaraVieira
SaraVieira approved these changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@SaraVieira SaraVieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you!

@SaraVieira SaraVieira merged commit c7002dc into codesandbox:master Jan 27, 2020
@MichaelDeBoey
Copy link
Contributor Author

MichaelDeBoey commented Jan 27, 2020

With pleasure! 🙂

@MichaelDeBoey MichaelDeBoey deleted the overmind/SearchDependenciesModal branch January 27, 2020 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@SaraVieira SaraVieira SaraVieira approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🧠 Overmind Indicates that this is related to the app's State Management 🔨 Refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MichaelDeBoey @lbogdan @SaraVieira