Skip to content

Conversation

@MichaelDeBoey
Copy link
Contributor

Follow-up of #3066

Things I did extra:

  • Change npmDependencyRemoved's signature to accept a string instead of { name: string }, because it only has 1 argument
  • Put all styles into the elements.ts file
  • Make AddResource a FunctionComponent
  • Move overmind subscriptions as close as possible to the components itself instead of passing it through

@MichaelDeBoey MichaelDeBoey added 🔨 Refactor 🧠 Overmind Indicates that this is related to the app's State Management labels Jan 18, 2020
@lbogdan
Copy link
Contributor

lbogdan commented Jan 18, 2020

Build for latest commit 6b8606d is at https://pr3361.build.csb.dev/s/new.

@lbogdan lbogdan temporarily deployed to pr3361 January 18, 2020 20:15 Inactive
@lbogdan lbogdan temporarily deployed to pr3361 January 19, 2020 13:07 Inactive
@lbogdan lbogdan temporarily deployed to pr3361 January 19, 2020 22:49 Inactive
@MichaelDeBoey
Copy link
Contributor Author

Ping @christianalfoni @SaraVieira

@lbogdan lbogdan temporarily deployed to pr3361 January 31, 2020 13:42 Inactive
@lbogdan lbogdan temporarily deployed to pr3361 January 31, 2020 18:00 Inactive
@lbogdan lbogdan temporarily deployed to pr3361 February 5, 2020 16:42 Inactive
@lbogdan lbogdan temporarily deployed to pr3361 February 5, 2020 23:40 Inactive
@SaraVieira
Copy link
Contributor

Closed for the same reason as the sidebar ones :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧠 Overmind Indicates that this is related to the app's State Management 🔨 Refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants