Skip to content

Fix textarea id changing on re render #3309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 11, 2020
Merged

Fix textarea id changing on re render #3309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1411297
fix textarea id rerendering
SaraVieira Jan 10, 2020
627b784
add autoid
SaraVieira Jan 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
"dependencies": {
"@codesandbox/common": "^1.0.8",
"@codesandbox/template-icons": "^1.1.0",
"@reach/auto-id": "^0.7.1",
"@reach/visually-hidden": "^0.7.0",
"@styled-system/css": "^5.1.4",
"add": "^2.0.6",
Expand Down
5 changes: 2 additions & 3 deletions packages/components/src/components/Input/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import React from 'react';
import styled from 'styled-components';
import css from '@styled-system/css';
import VisuallyHidden from '@reach/visually-hidden';
import { uniqueId } from 'lodash-es';
import { useId } from '@reach/auto-id';
import { Text } from '../Text';

const placeholderStyles = {
Expand Down Expand Up @@ -35,8 +35,7 @@ export const Input: React.FC<IInputProps> = ({
label,
...props
}) => {
const id = props.id || uniqueId('form_');

const id = useId(props.id);
return (
<>
{props.placeholder && !label ? (
Expand Down
4 changes: 2 additions & 2 deletions packages/components/src/components/SearchInput/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import React from 'react';
import styled from 'styled-components';
import css from '@styled-system/css';
import VisuallyHidden from '@reach/visually-hidden';
import { uniqueId } from 'lodash-es';
import { useId } from '@reach/auto-id';
import { Text } from '../Text';
import { InputComponent } from '../Input';
import { Element } from '../Element';
Expand Down Expand Up @@ -51,7 +51,7 @@ interface ISearchProps extends React.InputHTMLAttributes<HTMLInputElement> {
}

export const SearchInput: React.FC<ISearchProps> = ({ label, ...props }) => {
const id = props.id || uniqueId('form_');
const id = useId(props.id);

return (
<>
Expand Down
4 changes: 2 additions & 2 deletions packages/components/src/components/Select/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import React, { useCallback } from 'react';
import styled from 'styled-components';
import css from '@styled-system/css';
import VisuallyHidden from '@reach/visually-hidden';
import { uniqueId } from 'lodash-es';
import { useId } from '@reach/auto-id';
import { Text } from '../Text';
import { Element } from '../Element';

Expand Down Expand Up @@ -74,7 +74,7 @@ export const Select: React.FC<ISelectProps> = ({
[icon]
);

const id = props.id || uniqueId('form_');
const id = useId(props.id);

return (
<>
Expand Down
10 changes: 5 additions & 5 deletions packages/components/src/components/Textarea/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import styled, {
} from 'styled-components';
import css from '@styled-system/css';
import VisuallyHidden from '@reach/visually-hidden';
import { uniqueId } from 'lodash-es';
import { useId } from '@reach/auto-id';
import { Text } from '../Text';
import { Stack } from '../Stack';
import { InputComponent } from '../Input';
Expand Down Expand Up @@ -53,9 +53,9 @@ export const Textarea: React.FC<ITextareaProps> = ({
autosize,
...props
}) => {
const id = props.id || uniqueId('form_');
const [wordCount, setWordCount] = useState(0);
const [value, setValue] = useState('');
const id = useId(props.id);

const Wrapper = useCallback(
({ children }) =>
Expand Down Expand Up @@ -98,15 +98,15 @@ export const Textarea: React.FC<ITextareaProps> = ({
<>
{props.placeholder && !label ? (
<VisuallyHidden>
<label htmlFor={id}>{props.placeholder}</label>
<label htmlFor={props.id || id}>{props.placeholder}</label>
</VisuallyHidden>
) : null}
{label ? (
<Text
as="label"
size={2}
marginBottom={2}
htmlFor={id}
htmlFor={props.id || id}
style={{ display: 'block' }}
>
{label}
Expand All @@ -117,7 +117,7 @@ export const Textarea: React.FC<ITextareaProps> = ({
value={value}
onChange={update}
onKeyPress={keyPress}
id={id}
id={props.id || id}
{...props}
/>
{maxLength ? (
Expand Down
5 changes: 5 additions & 0 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3850,6 +3850,11 @@
hey-listen "^1.0.8"
style-value-types "^3.1.6"

"@reach/auto-id@^0.7.1":
version "0.7.1"
resolved "https://registry.yarnpkg.com/@reach/auto-id/-/auto-id-0.7.1.tgz#68ff4345b12c5ead6d0374a574480090b18a1b31"
integrity sha512-7bE/tCFc6KBMKkSfquJFpeZic+OHe+RAE2OHCN66felnleVwm6hr128d2UAp5vb1H12F6fm1kCUV9s3xNqSwMQ==

"@reach/router@^1.2.1":
version "1.2.1"
resolved "https://registry.yarnpkg.com/@reach/router/-/router-1.2.1.tgz#34ae3541a5ac44fa7796e5506a5d7274a162be4e"
Expand Down