Skip to content

Delete all experimentVSCode branches from the code #3283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 14, 2020
Merged

Delete all experimentVSCode branches from the code #3283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
893f7e4
Delete all experimentVSCode branches from the code
MichaelDeBoey Jan 7, 2020
81db1da
Fix types
MichaelDeBoey Jan 7, 2020
37125b0
Fully delete keybindingManager, since it's not doing anything anymore
MichaelDeBoey Jan 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions packages/app/src/app/overmind/actions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,12 +90,7 @@ export const modalOpened: Action<{
}
};

export const modalClosed: Action = ({ state, effects }) => {
// We just start it whenever it closes, if already started nothing happens
if (state.currentModal === 'preferences') {
effects.keybindingManager.start();
}

export const modalClosed: Action = ({ state }) => {
state.currentModal = null;
};

Expand Down
1 change: 0 additions & 1 deletion packages/app/src/app/overmind/effects/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ export { default as api } from './api';
export { default as browser } from './browser';
export { default as connection } from './connection';
export { default as jsZip } from './jsZip';
export { default as keybindingManager } from './keybindingManager';
export { default as live } from './live';
export { default as moduleRecover } from './moduleRecover';
export { default as notifications } from './notifications';
Expand Down
333 changes: 0 additions & 333 deletions packages/app/src/app/overmind/effects/keybindingManager.ts
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion packages/app/src/app/overmind/effects/settingsStore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ const allowedKeys = {
enableLigatures: 'settings.enableLigatures',
customVSCodeTheme: 'settings.customVSCodeTheme',
manualCustomVSCodeTheme: 'settings.manualCustomVSCodeTheme',
// experimentVSCode: 'settings.experimentVSCode',
};

export default {
Expand Down
6 changes: 1 addition & 5 deletions packages/app/src/app/overmind/factories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Contributor, PermissionType } from '@codesandbox/common/lib/types';
import { hasPermission } from '@codesandbox/common/lib/utils/permission';
import { IDerive, IState, json } from 'overmind';
import { IDerive, IState } from 'overmind';

import { AsyncAction } from '.';

Expand All @@ -26,10 +26,6 @@ export const withLoadApp = <T>(

effects.connection.addListener(actions.connectionChanged);
actions.internal.setStoredSettings();
effects.keybindingManager.set(
json(state.preferences.settings.keybindings || []) as any
);
effects.keybindingManager.start();
effects.codesandboxApi.listen(actions.server.onCodeSandboxAPIMessage);

if (state.jwt) {
Expand Down
1 change: 0 additions & 1 deletion packages/app/src/app/overmind/internalActions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,6 @@ export const closeModals: Action<boolean> = ({ state, effects }, isKeyDown) => {
}

state.currentModal = null;
effects.keybindingManager.start();
};

export const setCurrentSandbox: AsyncAction<Sandbox> = async (
Expand Down
Loading