Skip to content

🔨 Switch Header to use useOvermind #3218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 30, 2019
Merged

🔨 Switch Header to use useOvermind #3218

merged 4 commits into from
Dec 30, 2019

Conversation

@MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented Dec 16, 2019

Resubmission of #2856

Follow-up of #2644 & #2865

Things I did extra:

  • Extract useInterval into it's own file in app/hooks
  • Just use a single file for Action, ForkButton, Header, LikeButton, Logo, MenuBar, PickButton, RefreshButton, SandboxName & ShareButton to not pollute the project files unnecessarily
  • Make Action, Logo, MenuBar, PrivacyTooltip, Private, Public, RefreshButton, Unlisted & UpdateFound a FunctionComponent
  • Cleanup ActionProps
  • Put all styles into the elements.ts file
  • Delete PatronButton, SaveAllButton & ViewMode since they're not used anymore
  • Derive Header's prop type from Container's prop type

@MichaelDeBoey MichaelDeBoey added 🔨 Refactor 🧠 Overmind Indicates that this is related to the app's State Management labels Dec 16, 2019
@lbogdan lbogdan temporarily deployed to pr3218 December 16, 2019 22:34 Inactive
@lbogdan
Copy link
Contributor

lbogdan commented Dec 16, 2019 •
edited
Loading

Build for latest commit c6013dd is at https://pr3218.build.csb.dev/s/new.

@lbogdan lbogdan temporarily deployed to pr3218 December 30, 2019 14:57 Inactive
@SaraVieira SaraVieira merged commit 855407d into codesandbox:master Dec 30, 2019
@SaraVieira
Copy link
Contributor

SaraVieira commented Dec 30, 2019

Thank you!

@MichaelDeBoey
Copy link
Contributor Author

MichaelDeBoey commented Dec 30, 2019

With pleasure! 🙂

@MichaelDeBoey MichaelDeBoey deleted the overmind/Header branch December 30, 2019 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SaraVieira SaraVieira Awaiting requested review from SaraVieira

Assignees

No one assigned

Labels

🧠 Overmind Indicates that this is related to the app's State Management 🔨 Refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MichaelDeBoey @lbogdan @SaraVieira