Skip to content

Conversation

@SaraVieira
Copy link
Contributor

This updates the favicon to the new white logo
Screenshot 2019-12-13 at 15 01 59

@lbogdan lbogdan temporarily deployed to pr3200 December 13, 2019 14:07 Inactive
@lbogdan
Copy link
Contributor

lbogdan commented Dec 13, 2019

Build for latest commit 7e87a57 is at https://pr3200.build.csb.dev/s/new.

@CompuIves
Copy link
Member

I think we should use the one from codesandbox ci, that one also has the shadow.

@CompuIves
Copy link
Member

@SaraVieira
Copy link
Contributor Author

Can you ask Danny? He told me to use this one

@DannyRuchtie
Copy link
Contributor

https://ci.codesandbox.io/static/favicon.ico

@CompuIves this is not the rounded version.
As far as I know the rounded version bas created is the new one.

I removed the "shadow" side because of the legibility of the icon

@CompuIves
Copy link
Member

CompuIves commented Dec 16, 2019

Hmm, in my opinion I think this looks actually better:
image. Maybe it's because of retina? I can clearly see the shadow when visiting ci.codesandbox.io. I would argue it would be pretty hard to spot the rounded corners actually, but no strongly held opinions. We can also go with this one.

Can we give this one a dark outline as well? This way it shows well in all browsers + on all backgrounds.

@SaraVieira
Copy link
Contributor Author

All updated

@SaraVieira SaraVieira merged commit 07a0982 into master Dec 16, 2019
@SaraVieira SaraVieira deleted the favicon branch December 16, 2019 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants