🔨 Switch AliasDeploymentButton to use useOvermind #3120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelDeBoey
added
🔨 Refactor
🧠 Overmind
Contributor
|
Build for latest commit 2dade23 is at https://pr3120.build.csb.dev/s/new. |
christianalfoni
approved these changes
Dec 4, 2019
Contributor
christianalfoni
left a comment
christianalfoni
left a comment
There was a problem hiding this comment.
👍
Not tested as we can not test Zeit locally, but it is a simple change and looks good!
MichaelDeBoey
force-pushed
the
overmind/AliasDeploymentButton
branch
from
de0c1d3 to
8701fda
Compare
MichaelDeBoey
force-pushed
the
overmind/AliasDeploymentButton
branch
from
8701fda to
2dade23
Compare
Contributor
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resubmission of #2844
Follow-up of #2742
Things I did extra:
aliasDeployment's signature to accept astringinstead of{ id: string }, because it only has 1 argumentFunctionComponentinstead ofReact.FC, since it's the same, butFunctionComponentis a bit clearer I think