🔨 Switch NetlifyLogs to use useOvermind #3068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelDeBoey
added
🔨 Refactor
🧠 Overmind
Contributor
|
Build for latest commit 534893e is at https://pr3068.build.csb.dev/s/new. |
christianalfoni
requested changes
Nov 28, 2019
Contributor
christianalfoni
left a comment
christianalfoni
left a comment
There was a problem hiding this comment.
It looks great! I just have a couple of improvements on UX 😄
Tested:
- Deploy to Netlify
- Open logs
- With the changes suggested it now stays in "Waiting for build to start..." until it actually gets some logs
- Close log, and open again
Just merge suggestions and this is ready 😄
MichaelDeBoey
force-pushed
the
overmind/NetlifyLogs
branch
from
e682bf8 to
ec80b30
Compare
MichaelDeBoey
force-pushed
the
overmind/NetlifyLogs
branch
from
faf9afc to
eee2024
Compare
MichaelDeBoey
force-pushed
the
overmind/NetlifyLogs
branch
3 times, most recently
from
3da1a3f to
18b7556
Compare
MichaelDeBoey
force-pushed
the
overmind/NetlifyLogs
branch
from
18b7556 to
534893e
Compare
Contributor
|
awesome! works great!! |
Contributor
Author
|
With pleasure 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #2727
Things I did extra:
useEffectcallNetlifyLogsby a named export instead of adefault export