🔨 Switch Live to use useOvermind

[MichaelDeBoey]

Follow-up of #2663

Things I did extra:

• Change createLiveClicked's signature to accept a string instead of { sandboxId: string }, because it only has 1 argument
• Change onChatEnabledChange's signature to accept a boolean instead of { enabled: boolean }, because it only has 1 argument
• Remove unnecessary use of a Fragment (<></>)

[lbogdan]

Build for latest commit a8c21c2 is at https://pr3063.build.csb.dev/s/new.

[CompuIves]

Interesting, wouldn't this be less explicit (eg. I now need to know what's passed by going to the function call) and scalable (what if we want to add another option)? What's your opinion on this @christianalfoni?

[MichaelDeBoey]

I did this in recommendation of @christianalfoni in an earlier PR, but can't find it anywhere tho 😕

[SaraVieira]

Yeah, I remember this was christian idea in new code as it makes it cleaner

[MichaelDeBoey]

Yeah @christianalfoni said we should defo do it in new code.
But if I wanted, I could refactor them on the go

Can't find the comment where he said that anymore tho.
Too many PRs 😂😇

[christianalfoni]

Ah, yeah, there is no reason to pass an object anymore to actions. It was a requirement in Cerebral.

You could argue that the typing does not explicitly say sandboxId anymore, but payload. I just favour reduced syntax as if you were to write this action from scratch you would type it with string, because of our lazyness as developers 😂

[SaraVieira]

@CompuIves Can you please review this?

[CompuIves]

That makes sense, this looks good to me! Let's merge it if you've tested the component 😄.

Thanks for this conversion!

[SaraVieira]

YAY! All looks good to me too! Thank you!

[MichaelDeBoey]

With pleasure! 🙂