Skip to content

Conversation

@MichaelDeBoey
Copy link
Contributor

Follow-up of #2654

Things I did extra:

  • Change updateSubscriptionClicked's signature to accept a string instead of { coupon: string }, because it only has 1 argument
  • Put all styles into the elements.ts file
  • Move overmind subscriptions as close as possible to the components itself instead of passing it through
  • Type StripeInput's onChange prop
  • Type LinkButton's onClick prop

@MichaelDeBoey MichaelDeBoey added 🔨 Refactor 🧠 Overmind Indicates that this is related to the app's State Management labels Nov 21, 2019
@lbogdan lbogdan temporarily deployed to pr3055 November 21, 2019 20:52 Inactive
@lbogdan
Copy link
Contributor

lbogdan commented Nov 21, 2019

Build for latest commit a6d5197 is at https://pr3055.build.csb.dev/s/new.

@MichaelDeBoey MichaelDeBoey force-pushed the overmind/ChangeSubscription branch from 8e836b7 to 283ef86 Compare November 22, 2019 09:31
@lbogdan lbogdan temporarily deployed to pr3055 November 22, 2019 09:39 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/ChangeSubscription branch from 283ef86 to dc637c8 Compare November 30, 2019 19:58
@lbogdan lbogdan temporarily deployed to pr3055 November 30, 2019 21:43 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/ChangeSubscription branch from dc637c8 to bd8c2fc Compare December 3, 2019 19:38
@lbogdan lbogdan temporarily deployed to pr3055 December 3, 2019 20:54 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/ChangeSubscription branch 2 times, most recently from f07422d to 62b7601 Compare December 4, 2019 17:53
@lbogdan lbogdan temporarily deployed to pr3055 December 4, 2019 19:09 Inactive
Copy link
Contributor

@SaraVieira SaraVieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!!

@SaraVieira SaraVieira merged commit 27a2305 into codesandbox:master Dec 9, 2019
@MichaelDeBoey MichaelDeBoey deleted the overmind/ChangeSubscription branch December 9, 2019 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧠 Overmind Indicates that this is related to the app's State Management 🔨 Refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants