Skip to content

🔨 Switch GitHub to use useOvermind #3054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2019
Merged

🔨 Switch GitHub to use useOvermind #3054

merged 1 commit into from
Dec 9, 2019

Conversation

@MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented Nov 21, 2019

Follow-up of #2657

Things I did extra:

  • Make GitHub a FunctionComponent
  • Put all styles into the elements.ts file
  • Remove useCallback from updateUrl (since it's not necessary) and type it
  • Delete main.js, since it's not used anywhere
  • Type getFullGitHubUrl

@MichaelDeBoey MichaelDeBoey added 🔨 Refactor 🧠 Overmind Indicates that this is related to the app's State Management labels Nov 21, 2019
@lbogdan lbogdan temporarily deployed to pr3054 November 21, 2019 20:44 Inactive
@lbogdan
Copy link
Contributor

lbogdan commented Nov 21, 2019 •
edited
Loading

Build for latest commit 4b57174 is at https://pr3054.build.csb.dev/s/new.

@lbogdan lbogdan temporarily deployed to pr3054 November 30, 2019 21:30 Inactive
@lbogdan lbogdan temporarily deployed to pr3054 December 3, 2019 20:40 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the overmind/GitHub branch 2 times, most recently from 96b1cbe to 28103e9 Compare December 4, 2019 17:53
@lbogdan lbogdan temporarily deployed to pr3054 December 4, 2019 18:58 Inactive
@SaraVieira
Copy link
Contributor

SaraVieira commented Dec 9, 2019

wow, that file was random

Thank you so much!

@SaraVieira SaraVieira merged commit 1a25f3d into codesandbox:master Dec 9, 2019
@MichaelDeBoey
Copy link
Contributor Author

MichaelDeBoey commented Dec 9, 2019

With pleasure! 🙂

@MichaelDeBoey MichaelDeBoey deleted the overmind/GitHub branch December 9, 2019 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SaraVieira SaraVieira Awaiting requested review from SaraVieira

@christianalfoni christianalfoni Awaiting requested review from christianalfoni

Assignees

No one assigned

Labels

🧠 Overmind Indicates that this is related to the app's State Management 🔨 Refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MichaelDeBoey @lbogdan @SaraVieira