🔨 Refactor, 🧠 Overmind | /app/pages/common/Modals/DeploymentModal/index.js #2922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
84 tasks
Contributor
|
Build for latest commit ebe6882 is at https://pr2922.build.csb.dev/s/new. |
CompuIves
reviewed
Oct 24, 2019
Member
CompuIves
left a comment
CompuIves
left a comment
There was a problem hiding this comment.
Heyo! Did you have a chance to test the functionality of this? You can do that by trying to deploy a sandbox using ZEIT.
Contributor
Author
|
Yeah, actually I deployed two test sandboxes and everything was OK. |
Saeris
added
Hacktoberfest
🔨 Refactor
🧠 Overmind
SaraVieira
approved these changes
Dec 10, 2019
Contributor
SaraVieira
left a comment
SaraVieira
left a comment
There was a problem hiding this comment.
Hey!
Sorry for the delay :(
Looks awesome! Tested:
- Opening deploy
- Deploying to zeit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactors code as a part of hacktoberfest mentioned in #2621.
@Saeris @christianalfoni
What is the current behavior?
/app/pages/common/Modals/DeploymentModal/index.jswas usingCerebralWhat is the new behavior?
/app/pages/common/Modals/DeploymentModal/index.tsnow usingOvermindWhat steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.
injectandobserverwithuseOvermindTypescriptCubechild component and usedapp/components/Cubeinsteadyarn testyarn lintyarn typecheckChecklist