Skip to content

Fix flashing on loading Sandbox #2921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2019
Merged

Fix flashing on loading Sandbox #2921

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions packages/app/src/app/pages/Sandbox/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,19 @@
import React from 'react';
import Helmet from 'react-helmet';
import { Link } from 'react-router-dom';
import { getSandboxName } from '@codesandbox/common/lib/utils/get-sandbox-name';
import { Button } from '@codesandbox/common/lib/components/Button';
import Centered from '@codesandbox/common/lib/components/flex/Centered';
import Fullscreen from '@codesandbox/common/lib/components/flex/Fullscreen';
import Padding from '@codesandbox/common/lib/components/spacing/Padding';
import { getSandboxName } from '@codesandbox/common/lib/utils/get-sandbox-name';
import { inject, observer } from 'app/componentConnectors';
import { Title } from 'app/components/Title';
import { Skeleton } from 'app/components/Skeleton';
import { QuickActions } from 'app/pages/Sandbox/QuickActions';
import { NotFound } from 'app/pages/common/NotFound';
import { Navigation } from 'app/pages/common/Navigation';
import { Title } from 'app/components/Title';
import { GithubIntegration } from 'app/pages/common/GithubIntegration';
import { Navigation } from 'app/pages/common/Navigation';
import { NotFound } from 'app/pages/common/NotFound';
import { QuickActions } from 'app/pages/Sandbox/QuickActions';
import React from 'react';
import Helmet from 'react-helmet';
import { Link } from 'react-router-dom';

import Editor from './Editor';

class SandboxPage extends React.Component {
Expand Down Expand Up @@ -159,7 +160,9 @@ class SandboxPage extends React.Component {
}}
margin={1}
>
<Navigation title="Sandbox Editor" />
{store.editor.isLoading ? null : (
<Navigation title="Sandbox Editor" />
)}
<Centered
style={{ flex: 1, width: '100%', height: '100%' }}
horizontal
Expand Down