🔨 Refactor, 🧠 Overmind Hactoberfest | Refactor /app/pages/common/Modals/index.js #2902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Build for latest commit bed89b4 is at https://pr2902.build.csb.dev/s/new. |
Saeris
added
Hacktoberfest
🔨 Refactor
🧠 Overmind
84 tasks
Avi98
commented
Oct 25, 2019
| }; | ||
|
|
||
| export const modalClosed: Action = ({ state, effects }) => { | ||
| export const modalClosed: Action<any> = ({ state, effects }) => { |
…lient into use-overmind-modals
Avi98
commented
Oct 25, 2019
| return ( | ||
| <ThemeProvider | ||
| theme={{ | ||
| templateColor: templateColor(sandbox, templateDef), |
Author
There was a problem hiding this comment.
@SaraVieira also need your inputs here as types for templateColor's second argument and templateDef are incompatible.
added 2 commits
October 30, 2019 23:40
christianalfoni
approved these changes
Nov 20, 2019
Contributor
christianalfoni
left a comment
christianalfoni
left a comment
There was a problem hiding this comment.
Excellent stuff! About the typings it needs some review no matter, so this is perfectly okay for now 😄
Tested:
- Opening/closing several modals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactors code as a part of hacktoberfest mentioned in 2621 @SaraVieira, @Saeris
What is the current behavior?
/app/pages/common/Modals/index.js using Cerebral
What is the new behavior?
/app/pages/common/Modals/index.js using overmind
What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.
Checklist