Skip to content

🔨 Refactor, 🧠 Overmind Hactoberfest | Refactor /app/pages/Sandbox/Editor/Workspace/Files/DirectoryEntry/DirectoryChildren/ModuleEntry.js to use Overmind #2885 #2887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2019
Merged

🔨 Refactor, 🧠 Overmind Hactoberfest | Refactor /app/pages/Sandbox/Editor/Workspace/Files/DirectoryEntry/DirectoryChildren/ModuleEntry.js to use Overmind #2885 #2887

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 28 additions & 10 deletions ...oryEntry/DirectoryChildren/ModuleEntry.js → ...ryEntry/DirectoryChildren/ModuleEntry.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,28 @@
import { inject, observer } from 'app/componentConnectors';
import { Module, Directory } from '@codesandbox/common/lib/types';
import { useOvermind } from 'app/overmind';
// eslint-disable-next-line import/extensions
import getType from 'app/utils/get-type.ts';
import React from 'react';

import Entry from '../Entry';

const ModuleEntry = ({
store,
interface IModuleEntryProps {
module: Module;
setCurrentModule: (id: string) => void;
markTabsNotDirty: () => void;
depth: number;
renameModule: (title: string, moduleShortid: string) => void;
deleteEntry: (shortid: string, title: string) => void;
discardModuleChanges: (shortid: string) => void;
getModulePath: (
modules: Module[],
directories: Directory[],
id: string
) => string;
renameValidator: (id: string, title: string) => boolean;
}

const ModuleEntry: React.FC<IModuleEntryProps> = ({
module,
setCurrentModule,
markTabsNotDirty,
Expand All @@ -17,15 +33,17 @@ const ModuleEntry = ({
getModulePath,
renameValidator,
}) => {
const { currentModuleShortid } = store.editor;
const mainModuleId = store.editor.mainModule.id;

const {
state: {
editor: { mainModule, currentModuleShortid },
live,
},
} = useOvermind();
const isActive = module.shortid === currentModuleShortid;
const isMainModule = module.id === mainModuleId;
const isMainModule = module.id === mainModule.id;
const type = getType(module.title);
const hasError = module.errors.length;

const liveUsers = store.live.liveUsersByModule[module.shortid] || [];
const liveUsers = live.liveUsersByModule[module.shortid] || [];

const isNotSynced = module.savedCode && module.code !== module.savedCode;

Expand All @@ -52,4 +70,4 @@ const ModuleEntry = ({
);
};

export default inject('store')(observer(ModuleEntry));
export default ModuleEntry;