Skip to content

Conversation

@lusan
Copy link
Contributor

@lusan lusan commented Oct 20, 2019

What kind of change does this PR introduce?

Refactors code as a part of hacktoberfest mentioned in #2621.
@Saeris @christianalfoni

What is the current behavior?

packages packages/app/src/app/pages/Dashboard/Sidebar/index.js was using Cerebral

What is the new behavior?

packages /app/src/app/pages/Dashboard/Sidebar/index.tsx is using Overmind

What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.

  1. Replaced inject and hooksObserver with useOvermind
  2. yarn test
  3. yarn lint
  4. yarn typecheck

Checklist

  • Documentation
  • Testing
  • Ready to be merged
  • Added myself to contributors table

@lbogdan
Copy link
Contributor

lbogdan commented Oct 20, 2019

Build for latest commit 55fb28e is at https://pr2880.build.csb.dev/s/new.

@lusan lusan changed the title refactored dashboard sandbox index to overmind refactored /app/src/app/pages/Dashboard/Sidebar/index.tsx dashboard sandbox index to overmind Oct 20, 2019
@Saeris Saeris added Hacktoberfest 🔨 Refactor 🧠 Overmind Indicates that this is related to the app's State Management labels Oct 21, 2019
@SaraVieira SaraVieira merged commit 55fb28e into codesandbox:master Dec 9, 2019
@SaraVieira
Copy link
Contributor

Sorry for the delay but thank you so much :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧠 Overmind Indicates that this is related to the app's State Management 🔨 Refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants