🔨 Refactor(/app/pages/Dashboard/index): replace Cerebral with 🧠 Overmind #2833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armujahid
commented
Oct 17, 2019
| client.resetStore(); | ||
| } | ||
| useEffect(() => { | ||
| dashboard.dashboardMounted(); |
Contributor
Author
There was a problem hiding this comment.
How to fix this type error ? 🤔
Contributor
Author
There was a problem hiding this comment.
All CI checks (including typecheck) are green so It seems that this typecheck error was my environment specific.
Contributor
There was a problem hiding this comment.
May be an old thing that already got fixed
Contributor
Author
There was a problem hiding this comment.
CI typecheck is now failing because of this error after renaming the file to tsx.
84 tasks
SaraVieira
suggested changes
Oct 19, 2019
Contributor
SaraVieira
left a comment
SaraVieira
left a comment
There was a problem hiding this comment.
Can you please rename the file to tsx?
armujahid
force-pushed
the
apppagesDashboardindex
branch
from
1cb881d to
0aa295b
Compare
Contributor
Author
|
@SaraVieira done |
armujahid
commented
Oct 19, 2019
Contributor
Author
|
All green again :) |
SaraVieira
approved these changes
Oct 20, 2019
Contributor
SaraVieira
left a comment
SaraVieira
left a comment
There was a problem hiding this comment.
Looks good!
Thank you!!
MichaelDeBoey
added
🔨 Refactor
🧠 Overmind
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactor
/app/pages/Dashboard/index.js#2621 @Saeris @christianalfoniWhat is the current behavior?
It was using cerebral for state management
What is the new behavior?
It uses Overmind for state management with help of useOvermind hook
What steps did you take to test this? This is required before we can merge.
yarn lint
yarn typecheck (Currently failing. @Saeris @christianalfoni kindly guide how to fix this type error)
yarn test
Checklist