Skip to content

Conversation

@sajadhsm
Copy link
Contributor

What kind of change does this PR introduce?

Refactors code as a part of hacktoberfest mentioned in #2621.
@Saeris @christianalfoni

What is the current behavior?

/app/pages/Sandbox/Editor/Workspace/items/ConfigurationFiles/index.js was using Cerebral

What is the new behavior?

/app/pages/Sandbox/Editor/Workspace/items/ConfigurationFiles/index.tsx now using Overmind

What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.

  1. Replaced inject and observer with useOvermind
  2. Converted js files to ts and tsx
  3. Added some missing types!
    files.moduleCreated() also expected directoryShortid to be a string or null
  4. Ran yarn test
  5. Ran yarn lint
  6. Ran yarn typecheck

Checklist

  • Documentation N/A
  • Testing
  • Ready to be merged
  • Added myself to contributors table

Copy link
Contributor

@christianalfoni christianalfoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Awesome job! 👍 😄

Tested:

  • Open configuration files
  • Open existing file
  • Create new file

@christianalfoni christianalfoni merged commit 8d11130 into codesandbox:master Oct 17, 2019
@sajadhsm sajadhsm deleted the refactor-Workspace-items-ConfigurationFiles branch October 17, 2019 12:42
@MichaelDeBoey MichaelDeBoey added 🔨 Refactor 🧠 Overmind Indicates that this is related to the app's State Management labels Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧠 Overmind Indicates that this is related to the app's State Management 🔨 Refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants