Refactor /app/pages/common/Modals/NetlifyLogs/index.js to /app/pages/common/Modals/NetlifyLogs/index.tsx 🧠 Overmind | Hacktoberfest #2820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…common/Modals/NetlifyLogs/index.tsx
ganes1410
changed the title
christianalfoni
requested changes
Oct 17, 2019
Contributor
christianalfoni
left a comment
christianalfoni
left a comment
There was a problem hiding this comment.
This looks great! 👍 😄
It did break an import, but I created a PR for you to merge in and we are good to go: ganes1410#1
Tested:
- Open logs
- Close logs
- See logs being updated
Fix bad import
Contributor
Author
|
@christianalfoni Thanks for the help. I have merged your PR. |
84 tasks
Saeris
added
Hacktoberfest
🔨 Refactor
🧠 Overmind
Contributor
|
Duplicate of #2727 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactor #2621 @Saeris @christianalfoni
What is the current behavior?
It was using class component with js file, and cerebral for state management
What is the new behavior?
It now uses tsx instead of js. And Overmind is used for state management with help of
useOvermindhookWhat steps did you take to test this? This is required before we can merge.
yarn lintyarn testyarn typecheckChecklist