Skip to content

Conversation

@jyotiarora2610
Copy link
Contributor

@jyotiarora2610 jyotiarora2610 commented Oct 16, 2019

What kind of change does this PR introduce?

Refactors code as a part of hacktoberfest mentioned in #2621.
@Saeris @christianalfoni

What is the current behavior?

packages/app/src/app/pages/Sandbox/QuickActions/QuickActions.tsx was using Cerebral

What is the new behavior?

packages/app/src/app/pages/Sandbox/QuickActions/QuickActions.tsx is using Overmind

What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.

  1. Replaced inject and hooksObserver with useOvermind
  2. yarn test
  3. yarn lint
  4. yarn typecheck

Checklist

  • Documentation
  • Testing
  • Ready to be merged
  • Added myself to contributors table

@jyotiarora2610 jyotiarora2610 changed the title QuickActions refactoring QuickActions refactoring app/src/app/pages/Sandbox/QuickActions/QuickActions.tsx Oct 16, 2019
@lbogdan lbogdan temporarily deployed to pr2817 October 16, 2019 16:54 Inactive
@christianalfoni
Copy link
Contributor

Hi there @jyotiarora2610 and thanks for helping out!

For this PR to get through we would need the class based component to be refactored into a function component. You can take a look at for example: https://github.com/codesandbox/codesandbox-client/blob/master/packages/app/src/app/pages/Patron/index.tsx as a reference.

Let us know if you have any questions related to how to convert the methods of the class component into the function component approach 😄

@jyotiarora2610
Copy link
Contributor Author

Hi there @jyotiarora2610 and thanks for helping out!

For this PR to get through we would need the class based component to be refactored into a function component. You can take a look at for example: https://github.com/codesandbox/codesandbox-client/blob/master/packages/app/src/app/pages/Patron/index.tsx as a reference.

Let us know if you have any questions related to how to convert the methods of the class component into the function component approach 😄

Hi @christianalfoni I've done the required changes, please check

Copy link
Contributor

@SaraVieira SaraVieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loooks guuuud!

Thank you!

@SaraVieira SaraVieira merged commit a62cec4 into codesandbox:master Oct 19, 2019
@MichaelDeBoey MichaelDeBoey added 🔨 Refactor 🧠 Overmind Indicates that this is related to the app's State Management labels Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧠 Overmind Indicates that this is related to the app's State Management 🔨 Refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants