🔨 Refactor, 🧠 Overmind, Hacktoberfest - /app/pages/common/Modals/SelectSandboxModal/index.js #2816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliamartani
changed the title
christianalfoni
requested changes
Oct 17, 2019
Contributor
christianalfoni
left a comment
christianalfoni
left a comment
There was a problem hiding this comment.
This is looking great! 😄 It did include a broken import, but I made a PR you can merge: eliamartani#1
Then we are ready, tested:
- Open "Pick sandbox modal"
- Select a different sandbox
Broken import
Contributor
Author
Hi @christianalfoni , thanks for your comment. I accepted the pull request so you can review it again 😄 |
Saeris
added
Hacktoberfest
🔨 Refactor
🧠 Overmind
Contributor
Author
|
Hi guys, any chance of this PR being accepted? Just let me know. Thanks. |
christianalfoni
approved these changes
Oct 23, 2019
Contributor
christianalfoni
left a comment
christianalfoni
left a comment
There was a problem hiding this comment.
Great! :) Did same test again and it looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactors code as a part of hacktoberfest mentioned in #2621.
@Saeris @christianalfoni
What is the current behavior?
/app/src/app/pages/common/Modals/SelectSandboxModal/index.js was using inject from app/componentConnectors and written in JS.
What is the new behavior?
Uses useOvermind hook from app/overmind and was converted to tsx.
What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.
Checklist