🔨 Refactor, 🧠 Overmind, Hacktoberfest - /app/pages/common/Modals/LiveSessionEnded/index.js: convert to tsx and uses overmind #2810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to tsx and uses overmind Co-authored-by: Eliamar Tani <[email protected]>
…to tsx and uses overmind Co-authored-by: Eliamar Tani <[email protected]>
Contributor
Author
|
@lbogdan should I solve the conflict or you'll fix it? |
ftonato
changed the title
Contributor
|
@ftonato You should probably merge this PR with latest master, and solve the conflict in the process. |
Contributor
Author
|
@lbogdan I have made this change, please could you verify again? |
84 tasks
SaraVieira
suggested changes
Oct 19, 2019
packages/app/src/app/pages/common/Modals/LiveSessionEnded/index.tsx
Outdated
Show resolved
Hide resolved
Saeris
added
Hacktoberfest
🔨 Refactor
🧠 Overmind
Contributor
|
Build for latest commit 9ed9e27 is at https://pr2810.build.csb.dev/s/new. |
Contributor
Author
|
Hello @CompuIves, @Saeris, @christianalfoni, @lbogdan can we merge now? |
Contributor
|
Duplicate of #2807 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Eliamar Tani [email protected]
What kind of change does this PR introduce?
Refactors code as a part of hacktoberfest mentioned in #2621.
@Saeris @christianalfoni
What is the current behavior?
/app/pages/common/Modals/LiveSessionEnded/index.js was using inject from app/componentConnectors and written in JS.
What is the new behavior?
uses useOvermind hook from app/overmind and converted to tsx.
What steps did you take to test this? This is required before we can merge.
Checklist