🔨 Refactor, 🧠 Overmind, refactored OpenedTabs to use Overmind

[fullstackzach]

What kind of change does this PR introduce?

This PR Refactors /app/pages/Sandbox/Editor/Workspace/OpenedTabs/index.js to use Overmind

#2621

What steps did you take to test this? This is required before we can merge.

1. Ran yarn test successfully
2. Ran yarn lint successfully
3. Ran yarn start and confirmed that Tabs functionality in the workspace still works
4. Ran yarn typecheck successfully

Checklist

• Documentation
• Testing
• Ready to be merged
  
• Added myself to contributors table
  

[vercel]

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/codesandbox/codesandbox-client/82cm0vdh4
🌍 Preview: https://codesandbox-cl-git-fork-fullstackzach-overmind-refactor-a33e1c.codesandbox1.now.sh

[Saeris]

There's a few type errors that need to be resolved but otherwise this looks good! Please submit the requested changes and fix the following errors and I can merge this.

src/app/pages/Sandbox/Editor/Workspace/OpenedTabs/index.tsx(11,8): error TS1192: Module '"/home/circleci/codesandbox-client/packages/app/src/app/pages/Sandbox/Editor/Workspace/WorkspaceItem/index"' has no default export.
src/app/pages/Sandbox/Editor/Workspace/OpenedTabs/index.tsx(26,30): error TS2339: Property 'moduleShortid' does not exist on type 'ModuleTab | DiffTab'.
  Property 'moduleShortid' does not exist on type 'DiffTab'.
src/app/pages/Sandbox/Editor/Workspace/OpenedTabs/index.tsx(72,42): error TS2345: Argument of type '{ tabIndex: number; }' is not assignable to parameter of type 'number'.

Thanks!

[fullstackzach]

Thanks! I'll revisit this soon and adjust my PR

[lbogdan]

Build for latest commit 8c0d486 is at https://pr2769.build.csb.dev/s/new.

[CompuIves]

Heyo! Do you have time for the changes? Then it's ready to merge.

[fullstackzach]

Hi @CompuIves - Yeah I was going to attempt to make the changes @Saeris requested, probably in the next day or two. Typescript is pretty new to me so theres a little bit of a learning curve for me.

[fullstackzach]

Hi @CompuIves - Yeah I was going to attempt to make the changes @Saeris requested, probably in the next day or two. Typescript is pretty new to me so theres a little bit of a learning curve for me.

I actually probably will not get to this until November 9th. If it can wait I can work on it then - otherwise please take this branch forward in the meantime.

[MichaelDeBoey]

Hi @fullstackzach!

Did you get the time to check this one out yet? 🤔

[christianalfoni]

@fullstackzach I created a PR you can just approve on your end :) fullstackzach#1

It got quite complicated. Just merge it in and we will do a test on our end as well to verify before merging in.

[fullstackzach]

Hey all - sorry for the delay on this, life got quite busy. I’ll take a look at it tonight

[fullstackzach]

I made changes based on @Saeris's feedback to use a named export, but now when I run yarn lint I am getting the errors

app:   9:35  error  Unable to resolve path to module '@codesandbox/common/lib/utils/feature-flags'  import/no-unresolved
app:   9:35  error  Missing file extension for "@codesandbox/common/lib/utils/feature-flags"        import/extensions

and running yarn typecheck I get a whole ton of errors that seem unrelated to OpenedTabs. Could someone help? Unsure where to take this next. Thanks!

[christianalfoni]

Tested:

• Checked styling and icons of explorer, looking good!

OpenedTabs is a component not in use actually, so all okay. Nice to get the typing fixed!