Skip to content

Conversation

@Infi-Knight
Copy link

What kind of change does this PR introduce?

Refactors code as a part of hacktoberfest mentioned in #2621.
@Saeris @christianalfoni

What is the current behavior?

app/pages/Sandbox/Editor/Workspace/Dependencies/AddVersion/index.js was using Cerebral

What is the new behavior?

AddVersion now uses overmind hook from the new state management tool, Overmind.

What steps did you take to test this? This is required before we can merge.

  1. Replaced inject and hooksObserver with useOvermind
  2. Convert AddVersion class component to functional component.
  3. Add searchDependencies to the list of values the ModalName type can take in app/overmind/actions.ts
  4. Use named export in AddVersion and update pages/Sandbox/Editor/Workspace/Dependencies/index.tsx accordingly.
  5. Ran yarn test
  6. Ran yarn lint

Checklist

  • Documentation
  • Testing
  • Ready to be merged
  • Added myself to contributors table

@vercel
Copy link

vercel bot commented Oct 13, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/codesandbox/codesandbox-client/adbrgu8un
🌍 Preview: https://codesandbox-cl-git-fork-infi-knight-refactor-dependencie-911089.codesandbox1.now.sh

@vercel vercel bot temporarily deployed to staging October 13, 2019 19:27 Inactive
@Saeris Saeris added Hacktoberfest 🔨 Refactor 🧠 Overmind Indicates that this is related to the app's State Management labels Oct 14, 2019
@CompuIves
Copy link
Member

Seems to work well! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧠 Overmind Indicates that this is related to the app's State Management 🔨 Refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants