/app/pages/common/Modals/PreferencesModal/PaymentInfo/index 🔨 Refactor 🧠 Overmind Hacktoberfest #2763
Conversation
…tsx to use overmind
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/codesandbox/codesandbox-client/1jfs782up |
Saeris
added
Hacktoberfest
🔨 Refactor
🧠 Overmind
|
Hello! Thanks for the contribution! This looks good to me, could you also test the flow you've changed so we're sure it works? Again, thanks for the contribution! |
|
@CompuIves Tried to test this, but getting errors on duplicate objects, live/test mode etc. from Stripe. Tried both using test card and my own card, getting same error. It does load everything and passes the token correctly, so I would say this is okay! I am merging it in, but we should test this after deployment |
| import { PreviewSettings } from './EditorPageSettings/PreviewSettings'; | ||
| import { CodeFormatting } from './CodeFormatting'; | ||
| import { PaymentInfo } from './PaymentInfo'; | ||
| import PaymentInfo from './PaymentInfo'; |
4 participants
…tsx to use overmind
What kind of change does this PR introduce?
This is part of the requested refactor for hacktoberfest as mentioned #2621
@Saeris @christianalfoni
What is the current behavior?
Previously it was utilizing inject and hooksObserver from app/componentConnectors.
What is the new behavior?
uses useOvermind
What steps did you take to test this? This is required before we can merge.
yarn lint
yarn test
yarn typecheck
Checklist