🔨Refactored 🧠 Overmind Hacktober | /app/pages/common/Modals/SearchDependenciesModal/index.js : refactor to tsx #2756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/codesandbox/codesandbox-client/a5uq1xjly |
hetpatel33
force-pushed
the
refactor-modal-search-dependencies-modal
branch
from
eb70b51 to
8180099
Compare
hetpatel33
changed the title
Saeris
added
Hacktoberfest
🔨 Refactor
🧠 Overmind
Saeris
suggested changes
Oct 21, 2019
Contributor
Saeris
left a comment
Saeris
left a comment
There was a problem hiding this comment.
We'd like to move everything over to named exports, so if you could commit the suggested changes and update any import references in the code base for this file, then we can get this merged. Thanks for the contribution!
packages/app/src/app/pages/common/Modals/SearchDependenciesModal/index.tsx
Outdated
Show resolved
Hide resolved
packages/app/src/app/pages/common/Modals/SearchDependenciesModal/index.tsx
Outdated
Show resolved
Hide resolved
…uses overmind and convert to tsx
Review Suggestions Co-Authored-By: Drake Costa <[email protected]>
hetpatel33
force-pushed
the
refactor-modal-search-dependencies-modal
branch
from
c021346 to
322db68
Compare
Contributor
Author
|
@Saeris |
Contributor
|
Build for latest commit 322db68 is at https://pr2756.build.csb.dev/s/new. |
Contributor
|
Duplicate of #2747 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactors code as a part of hacktoberfest mentioned in #2621.
@Saeris @christianalfoni @SaraVieira
What is the current behavior?
/app/pages/common/Modals/SearchDependenciesModal/index.js was written in JS.
What is the new behavior?
converted to tsx.
What steps did you take to test this? This is required before we can merge.
Checklist