Skip to content

Conversation

@stackyism
Copy link
Contributor

What kind of change does this PR introduce?

Refactors code as a part of hacktoberfest mentioned in #2621.
@Saeris @christianalfoni

What is the current behavior?

VisitSiteButton.tsx was using inject and hooksObserver from app/componentConnectors

What is the new behavior?

uses useOvermind hook from app/overmind

What steps did you take to test this? This is required before we can merge.

  1. Deployed app on local using yarn start.
  2. From sandbox workspace deployed https://csb-ooxu7.netlify.com using Netlify beta.
    In this process verified the link text Building... and then Visit.
  3. Checked functionality of Visit and it was working fine.
  4. Ran yarn lint, yarn test & yarn typecheck successfully.

Checklist

  • Documentation
  • Testing
  • Ready to be merged
  • Added myself to contributors table

@vercel
Copy link

vercel bot commented Oct 10, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/codesandbox/codesandbox-client/jn4kj8iv1
🌍 Preview: https://codesandbox-clien-git-fork-stackyism-refactor-visit-site-df732e.codesandbox1.now.sh

@stackyism stackyism force-pushed the refactor-visit-site-button branch from a61841b to 7838122 Compare October 11, 2019 23:27
@vercel vercel bot temporarily deployed to staging October 11, 2019 23:27 Inactive
@CompuIves
Copy link
Member

Incredible! Very good test steps, I appreciate it. Thanks a lot!

@CompuIves CompuIves merged commit 15a0626 into codesandbox:master Oct 12, 2019
@stackyism
Copy link
Contributor Author

Wow! Thank you so much @CompuIves .
This is my first ever open source contribution. :D
It means a lot coming from you. :)

@MichaelDeBoey MichaelDeBoey added 🔨 Refactor 🧠 Overmind Indicates that this is related to the app's State Management labels Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧠 Overmind Indicates that this is related to the app's State Management 🔨 Refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants