Skip to content

🔨 Refactored 🧠 Overmind Hacktober | /app/pages/Sandbox/ZenModeIntroductionModal/index.js #2669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 7, 2019
Merged

🔨 Refactored 🧠 Overmind Hacktober | /app/pages/Sandbox/ZenModeIntroductionModal/index.js #2669

merged 5 commits into from
Oct 7, 2019

Conversation

@NabeelahY
Copy link
Contributor

@NabeelahY NabeelahY commented Oct 6, 2019

What kind of change does this PR introduce?

• Refactor code to use overmind #2621
• Rename file /app/pages/Sandbox/ZenModeIntroductionModal/index.js to .tsx
• Rename file /app/pages/Sandbox/ZenModeIntroductionModal/elements.js to .ts

@Saeris @christianalfoni @SaraVieira

What is the current behavior?

/app/pages/Sandbox/ZenModeIntroductionModal/index.js was using inject and hooksObserver from /app/componentConnectors

What is the new behavior?

Uses useOvermind from /app/overmind

What steps did you take to test this?

Ran yarn lint and yarn test

Checklist

  • Documentation
  • Testing
  • Ready to be merged
  • Added myself to contributors table

@vercel
Copy link

vercel bot commented Oct 6, 2019 •
edited
Loading

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://codesandbox-cl-git-fork-nabeelahy-refactor-zenmodeintrod-10c873.codesandbox1.now.sh

@vercel vercel bot temporarily deployed to staging October 6, 2019 17:07 Inactive
@vercel vercel bot temporarily deployed to staging October 6, 2019 17:12 Inactive
@vercel vercel bot temporarily deployed to staging October 6, 2019 17:17 Inactive
@vercel vercel bot temporarily deployed to staging October 6, 2019 17:19 Inactive
SaraVieira
SaraVieira approved these changes Oct 7, 2019
View reviewed changes
Copy link
Contributor

@SaraVieira SaraVieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!! Thank You

@SaraVieira SaraVieira merged commit 6f60ac6 into codesandbox:master Oct 7, 2019
@Saeris Saeris added Hacktoberfest 🔨 Refactor 🧠 Overmind Indicates that this is related to the app's State Management labels Oct 8, 2019
@kiliman kiliman mentioned this pull request Oct 18, 2019
Closed
84 tasks
@MichaelDeBoey MichaelDeBoey mentioned this pull request Nov 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@SaraVieira SaraVieira SaraVieira approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🧠 Overmind Indicates that this is related to the app's State Management 🔨 Refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NabeelahY @SaraVieira @Saeris @myfineprint