Skip to content

Conversation

@ShahAnuj2610
Copy link
Contributor

@ShahAnuj2610 ShahAnuj2610 commented Oct 6, 2019

What kind of change does this PR introduce?

  • refactor a class to functional component to use useOvermind hook
  • convert js to ts
  • fix params sent to notificationAdded
  • add myself as contributor

@Saeris @christianalfoni

What is the current behavior?

  • was using inject and hooksObserver from app/componentConnectors
  • message and style param in notificationAdded

What is the new behavior?

  • uses useOvermind from app/overmind
  • title and notificationStyle in notificationAdded

What steps did you take to test this?

  • convert class component to functional component
  • replace state management using hooks useState

Checklist

  • Documentation
  • Testing
  • Ready to be merged
  • Added myself to contributors table

@vercel
Copy link

vercel bot commented Oct 6, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://codesandbox-client-git-fork-shahanuj2610-master.codesandbox1.now.sh

@vercel vercel bot temporarily deployed to staging October 6, 2019 08:37 Inactive
@ShahAnuj2610 ShahAnuj2610 changed the title refactor /app/pages/common/Modals/FeedbackModal/Feedback.js 🔨 Refactored 🧠 Overmind Hacktober /app/pages/common/Modals/FeedbackModal/Feedback.js Oct 6, 2019
@vercel vercel bot temporarily deployed to staging October 6, 2019 09:30 Inactive
@vercel vercel bot temporarily deployed to staging October 6, 2019 09:31 Inactive
@vercel vercel bot temporarily deployed to staging October 6, 2019 16:36 Inactive
@vercel vercel bot temporarily deployed to staging October 7, 2019 21:43 Inactive
@SaraVieira
Copy link
Contributor

Thank you so much! I reverted the contributors thing as there is a version mismatch and will use the bot :)

@all-contributors-bot please add ShahAnuj2610 for code

@allcontributors
Copy link
Contributor

@SaraVieira

I've put up a pull request to add @ShahAnuj2610! 🎉

@vercel vercel bot temporarily deployed to staging October 7, 2019 21:46 Inactive
@SaraVieira SaraVieira merged commit 2f6577e into codesandbox:master Oct 7, 2019
@Saeris Saeris added Hacktoberfest 🔨 Refactor 🧠 Overmind Indicates that this is related to the app's State Management labels Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧠 Overmind Indicates that this is related to the app's State Management 🔨 Refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants