update Overmind to get correct reaction type #2641
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://codesandbox-client-git-latest-overmind.codesandbox1.now.sh |
Closed
4 tasks
Contributor
|
@christianalfoni typecheck is failing |
Contributor
Author
|
Closed as fixed in: #2638 (review) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update fixes typing of Reaction and also Overmind will now pass the returned result of the first callback as the argument to the next callback.
Should verify by running project and play around a bit, but we we have our own wrapper currently which should not be affected by this. The good thing is that the change of Reaction now fits with the way we use the wrapper as well.