Skip to content

🔨 Refactored 🧠 Overmind Hacktober | app/pages/index.tsx : refactor to replace Cerebral with Overmind #2630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2019
Merged

🔨 Refactored 🧠 Overmind Hacktober | app/pages/index.tsx : refactor to replace Cerebral with Overmind #2630

merged 1 commit into from
Oct 3, 2019

Conversation

@chinmaychaudhary
Copy link
Contributor

@chinmaychaudhary chinmaychaudhary commented Oct 3, 2019 •
edited
Loading

What kind of change does this PR introduce?

Refactors code as a part of hacktoberfest mentioned in #2621.
@Saeris @christianalfoni

What is the current behavior?

app/pages/index.tsx was using inject and hooksObserver from app/componentConnectors

What is the new behavior?

uses useOvermind from app/overmind

What steps did you take to test this?

Opened the homepage, /s/new page
ran yarn lint and yarn typecheck

Checklist

  • Documentation: N/A
  • Testing
  • Ready to be merged
  • Added myself to contributors table

@vercel vercel bot temporarily deployed to staging October 3, 2019 17:03 Inactive
@vercel
Copy link

vercel bot commented Oct 3, 2019 •
edited
Loading

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://codesandbox-client-git-fork-chinmay17-refactor-app-pages-index.codesandbox1.now.sh

@chinmaychaudhary chinmaychaudhary changed the title app/pages/index.tsx : refactor to replace Cerebral with Overmind 🔨 Refactored 🧠 Overmind Hacktober | app/pages/index.tsx : refactor to replace Cerebral with Overmind Oct 3, 2019
@chinmaychaudhary chinmaychaudhary mentioned this pull request Oct 3, 2019
Closed
84 tasks
SaraVieira
SaraVieira approved these changes Oct 3, 2019
View reviewed changes
Copy link
Contributor

@SaraVieira SaraVieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@SaraVieira
Copy link
Contributor

SaraVieira commented Oct 3, 2019

Thank you so much 🎉

@SaraVieira SaraVieira merged commit 8ad2cbe into codesandbox:master Oct 3, 2019
@SaraVieira
Copy link
Contributor

SaraVieira commented Oct 3, 2019

@all-contributors bot please add chinmay17 for code

@allcontributors allcontributors bot mentioned this pull request Oct 3, 2019
Merged
@allcontributors
Copy link
Contributor

allcontributors bot commented Oct 3, 2019

@SaraVieira

I've put up a pull request to add @chinmay17! 🎉

@chinmaychaudhary
Copy link
Contributor Author

chinmaychaudhary commented Oct 3, 2019

@SaraVieira Woah! That was quick! This is my first open-source PR getting merged. And that too for codesandbox! Thank you so much!

@chinmaychaudhary chinmaychaudhary deleted the refactor-app-pages-index branch October 3, 2019 17:37
@Saeris Saeris added Hacktoberfest 🔨 Refactor 🧠 Overmind Indicates that this is related to the app's State Management labels Oct 3, 2019
@MichaelDeBoey MichaelDeBoey mentioned this pull request Oct 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@SaraVieira SaraVieira SaraVieira approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🧠 Overmind Indicates that this is related to the app's State Management 🔨 Refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chinmaychaudhary @SaraVieira @Saeris