Skip to content

Conversation

@yeion7
Copy link
Contributor

@yeion7 yeion7 commented Oct 2, 2019

What kind of change does this PR introduce?

update

What is the current behavior?

the new sandbox modal has a few accessibilities issues

What is the new behavior?

use Reakit for tab

What steps did you take to test this?

Checklist

  • Documentation
  • Testing
  • Ready to be merged
  • Added myself to contributors table

@vercel
Copy link

vercel bot commented Oct 2, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://codesandbox-clie-git-fork-yeion7-improve-new-sandbox-mod-93ccaa.codesandbox1.now.sh

@vercel vercel bot temporarily deployed to staging October 2, 2019 22:07 Inactive
@yeion7 yeion7 changed the title improve new sandbox modal a11y improve new sandbox tabs a11y Oct 2, 2019
@yeion7 yeion7 changed the title improve new sandbox tabs a11y new sandbox tabs a11y Oct 3, 2019
@SaraVieira
Copy link
Contributor

Amazing! Thank you so much!

You have been an amazing help!!!

@SaraVieira SaraVieira merged commit 75a6f04 into codesandbox:master Oct 3, 2019
@SaraVieira
Copy link
Contributor

@all-contributors bot please add yeion7 for code

@allcontributors
Copy link
Contributor

@SaraVieira

I've put up a pull request to add @yeion7! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants