Skip to content

fix eslint issues in url-listeners #2600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 2, 2019
Merged

fix eslint issues in url-listeners #2600

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5c57ab
refactor(url-listeners): fix eslint issues
armujahid Sep 29, 2019
784f996
refactor(url-listeners): remove unnecessary eslint-disable no-console
armujahid Oct 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions packages/sandbox-hooks/url-listeners.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
import { dispatch, isStandalone, listen } from 'codesandbox-api';

const origHistoryProto = window.history.__proto__; // eslint-disable-line no-proto
const historyList = [];
let historyPosition = -1;
let disableNextHashChange = false;

function sendUrlChange(url) {
dispatch({
type: 'urlchange',
Expand All @@ -9,13 +14,6 @@ function sendUrlChange(url) {
});
}

/* eslint-disable no-console */

const origHistoryProto = window.history.__proto__; // eslint-disable-line no-proto
const historyList = [];
let historyPosition = -1;
let disableNextHashChange = false;

function pushHistory(url, state) {
// remove "future" locations
historyList.splice(historyPosition + 1);
Expand Down