moved instantiation of vscode to effect, written components, reviewed #2510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://codesandbox-client-git-vscodeeffect.codesandbox1.now.sh |
Contributor
|
Build for latest commit 6b5f5b7 is at https://pr2510.build.csb.dev/s/new. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactor which prepares for putting in the new VSCode. we can actually make this part of master to save some work later. Basically this is what I did:
vscodeeffectmanagerdirectly, except for VSCode and MonacoVSCodeComponent as these will be replaced later anywaysvscodeeffect, with notes on what needs to be moved into that effectHopefully this helps draw the picture further on how this new VSCode concept should work :)