Skip to content

Conversation

@elrumordelaluz
Copy link
Contributor

It is a css fix that allow to view the Buttons when hovering the EntryContainer in case the name of the project is too long.

Current
codesandbox

Fix
codesandbox_2

Checklist:

  • Documentation N/A
  • [ X] Tests N/A
  • [ X] Ready to be merged
  • [X ] Added myself to contributors table

@CompuIves
Copy link
Member

Woooow this is great!! Could you fix the conflicts (I think just adding yourself again is sufficient)? Would love to merge this quickly, thanks for fixing this!

@elrumordelaluz
Copy link
Contributor Author

elrumordelaluz commented Oct 16, 2017

There was an undefined returned when I run yarn add-contributor the first time with an exit:

error Command failed with exit code 1.

Same when I run it again
all-contribs

Let me know if there's a workaround, happy to help fix these conflicts asap.

ps/ probably related

@CompuIves
Copy link
Member

Yap, I think I've seen that issue before. I think the files still get generated, but it returns a wrong error code. Does it generate new files for you? Otherwise you can just remove the contributors changes from the PR and I'll add you manually.

@CompuIves
Copy link
Member

Ah, went ahead and fixed the merge conflict 😄

@CompuIves CompuIves merged commit d4fc19f into codesandbox:master Oct 16, 2017
@elrumordelaluz
Copy link
Contributor Author

I see right now the notifications, cool thank you @CompuIves!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants