add contributing guide #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@CompuIves Please review 😬 |
CompuIves
reviewed
Oct 12, 2017
CONTRIBUTING.md
Outdated
|
|
||
| ## Submitting a Pull Request | ||
|
|
||
| Please go through existing pull requests and check if somebody else is already working on this. |
Member
There was a problem hiding this comment.
Maybe also mention to look through the issues, we have a tag for it.
Author
There was a problem hiding this comment.
ohh yes, the someone working on it tag
Member
|
Yas! This is great! Left one comment and I have another request. Maybe it would be good to create a PR template where we mention that you should add yourself to the contributors list? |
Member
|
Awesome! Thanks! |
Author
|
We can close #221 now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.