Add Google fonts picker #2328
Merged
Add Google fonts picker #2328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaraVieira
force-pushed
the
google-fonts
branch
from
a723a97 to
dfd3223
Compare
SaraVieira
commented
Aug 24, 2019
MichaelDeBoey
suggested changes
Aug 24, 2019
Contributor
MichaelDeBoey
left a comment
MichaelDeBoey
left a comment
There was a problem hiding this comment.
Awesome addition @SaraVieira!
packages/app/src/app/pages/Sandbox/Editor/Workspace/Dependencies/index.js
Outdated
Show resolved
Hide resolved
packages/app/src/app/pages/Sandbox/Editor/Workspace/Dependencies/index.js
Outdated
Show resolved
Hide resolved
packages/app/src/app/pages/Sandbox/Editor/Workspace/Dependencies/ExternalFonts/index.js
Outdated
Show resolved
Hide resolved
walaura
reviewed
Aug 26, 2019
packages/app/src/app/pages/Sandbox/Editor/Workspace/Dependencies/AddFont/FontPicker/List.tsx
Outdated
Show resolved
Hide resolved
walaura
reviewed
Aug 26, 2019
packages/app/src/app/pages/Sandbox/Editor/Workspace/Dependencies/AddFont/FontPicker/List.tsx
Outdated
Show resolved
Hide resolved
walaura
reviewed
Aug 26, 2019
packages/app/src/app/pages/Sandbox/Editor/Workspace/Dependencies/AddFont/FontPicker/index.tsx
Show resolved
Hide resolved
walaura
reviewed
Aug 26, 2019
packages/app/src/app/pages/Sandbox/Editor/Workspace/Dependencies/AddFont/FontPicker/index.tsx
Outdated
Show resolved
Hide resolved
walaura
reviewed
Aug 26, 2019
packages/app/src/app/pages/Sandbox/Editor/Workspace/Dependencies/AddFont/FontPicker/index.tsx
Outdated
Show resolved
Hide resolved
walaura
reviewed
Aug 26, 2019
packages/app/src/app/pages/Sandbox/Editor/Workspace/Dependencies/ExternalFonts/index.js
Outdated
Show resolved
Hide resolved
SaraVieira
force-pushed
the
google-fonts
branch
from
ad79b3f to
1b951dc
Compare
MichaelDeBoey
suggested changes
Aug 26, 2019
packages/app/src/app/pages/Sandbox/Editor/Workspace/Dependencies/AddFont/FontPicker/List.tsx
Outdated
Show resolved
Hide resolved
packages/app/src/app/pages/Sandbox/Editor/Workspace/Dependencies/AddFont/FontPicker/List.tsx
Outdated
Show resolved
Hide resolved
SaraVieira
force-pushed
the
google-fonts
branch
from
e05d1ec to
f24b47c
Compare
walaura
approved these changes
Aug 27, 2019
packages/app/src/app/pages/Sandbox/Editor/Workspace/Dependencies/AddFont/FontPicker/index.tsx
Show resolved
Hide resolved
CompuIves
reviewed
Aug 27, 2019
packages/app/src/app/pages/Sandbox/Editor/Workspace/items/Files/index.js
Outdated
Show resolved
Hide resolved
CompuIves
reviewed
Aug 27, 2019
CompuIves
reviewed
Aug 27, 2019
packages/app/src/app/pages/Sandbox/Editor/Workspace/Dependencies/AddFont/FontPicker/List.tsx
Outdated
Show resolved
Hide resolved
SaraVieira
force-pushed
the
google-fonts
branch
from
349a810 to
c0fa388
Compare
…es/AddFont/FontPicker/List.tsx Co-Authored-By: Michaël De Boey <[email protected]>
SaraVieira
force-pushed
the
google-fonts
branch
from
1649242 to
6fd79c2
Compare
Contributor
|
Build for latest commit 3872deb is at https://pr2328.build.csb.dev/s/new. |
yeion7
reviewed
Oct 24, 2019
packages/app/src/app/pages/Sandbox/Editor/Workspace/Dependencies/index.tsx
Show resolved
Hide resolved
packages/app/src/app/pages/Sandbox/Editor/Workspace/Dependencies/ExternalFonts/index.js
Outdated
Show resolved
Hide resolved
Contributor
|
this is an awesome feature @SaraVieira ! , I just left a couple things for a11y |
CompuIves
reviewed
Oct 25, 2019
packages/app/src/app/pages/Sandbox/Editor/Workspace/Dependencies/AddFont/FontPicker/index.tsx
Outdated
Show resolved
Hide resolved
CompuIves
requested changes
Oct 25, 2019
Member
CompuIves
left a comment
CompuIves
left a comment
There was a problem hiding this comment.
Veeery clean! Left one comment about an arrow, then it should be able to get in :D
…es/AddFont/FontPicker/index.tsx Co-Authored-By: Ives van Hoorne <[email protected]>
Member
|
YES! Here we go! |
CompuIves
approved these changes
Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the import of google fonts in the assets and creates a google font importer that will preview all the fonts
It also fixes two issues in master