Skip to content

Conversation

@Saeris
Copy link
Contributor

@Saeris Saeris commented Jul 27, 2019

This update adds a new MultiAction Button to be used for Following Templates, a prototype can be found here:

https://codesandbox.io/s/codesadbox-6vgjh

Additionally, this includes some refactoring and additions to common components. Button has been updated with a new Link component. Link can be used to both create an internal or external Link using a single API, intelligently using either a React Router link or an anchor tag with the appropriate attributes.

The MultiAction Button extends Button, sharing it's styles and base props, and uses Reakit under the hood to provide full keyboard accessibility.

Theme has been reorganized and extended with a set of fonts taken from the design system files in Figma. Additionally a set of breakpoint utilities was added, based on those found in the React documentation site.

A new withoutProps has been added that can be used to exclude props from being passed down to a component. This is useful for styled components, which sometimes pass down non-HTML attributes which cause console errors. Example usage can be observed in the MultiAction button elements.ts.

An error was fixed in Dependencies/VersionEntry for incorrect use of selected on an option element.

NotOwnedSandboxInfo now has a Follow Template button.

TODO:

  • [ ]: Add interactivity to the Follow Template button
  • [ ]: Test functionality
  • [ ]: Incorporate requested changes

@lbogdan lbogdan temporarily deployed to pr2225 July 27, 2019 15:15 Inactive
@Saeris Saeris changed the title 🚧 Follow Templates ✨ Follow Templates Jul 27, 2019
@Saeris Saeris added the ✨ Feature Indicates that this adds a new feature. label Jul 27, 2019
@lbogdan lbogdan temporarily deployed to pr2225 July 30, 2019 10:46 Inactive
@lbogdan lbogdan temporarily deployed to pr2225 August 1, 2019 09:04 Inactive
@SaraVieira SaraVieira force-pushed the follow-templates branch 2 times, most recently from 1a936e5 to a372a67 Compare August 12, 2019 13:09
@lbogdan lbogdan temporarily deployed to pr2225 August 12, 2019 13:19 Inactive
@lbogdan lbogdan temporarily deployed to pr2225 August 12, 2019 16:18 Inactive
@lbogdan lbogdan temporarily deployed to pr2225 August 12, 2019 17:58 Inactive
@vercel vercel bot temporarily deployed to staging September 19, 2019 07:59 Inactive
@vercel
Copy link

vercel bot commented Sep 19, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://codesandbox-client-git-follow-templates.codesandbox1.now.sh

@vercel vercel bot temporarily deployed to staging September 19, 2019 08:48 Inactive
@vercel vercel bot temporarily deployed to staging September 19, 2019 09:26 Inactive
@vercel vercel bot temporarily deployed to staging September 19, 2019 10:12 Inactive
@vercel vercel bot temporarily deployed to staging September 19, 2019 11:20 Inactive
@vercel vercel bot temporarily deployed to staging September 19, 2019 11:23 Inactive
@vercel vercel bot temporarily deployed to staging September 19, 2019 11:45 Inactive
@vercel vercel bot temporarily deployed to staging September 19, 2019 13:12 Inactive
@vercel vercel bot temporarily deployed to staging September 19, 2019 15:15 Inactive
@vercel vercel bot temporarily deployed to staging September 19, 2019 15:41 Inactive
@lbogdan lbogdan temporarily deployed to pr2225 November 30, 2019 17:24 Inactive
@lbogdan lbogdan temporarily deployed to pr2225 November 30, 2019 18:05 Inactive
@lbogdan lbogdan temporarily deployed to pr2225 December 2, 2019 10:05 Inactive
@lbogdan lbogdan temporarily deployed to pr2225 December 2, 2019 10:16 Inactive
@lbogdan lbogdan temporarily deployed to pr2225 December 3, 2019 14:26 Inactive
@lbogdan lbogdan temporarily deployed to pr2225 December 3, 2019 17:48 Inactive
@lbogdan lbogdan temporarily deployed to pr2225 December 3, 2019 18:26 Inactive
@lbogdan lbogdan temporarily deployed to pr2225 December 4, 2019 15:48 Inactive
@CompuIves CompuIves marked this pull request as ready for review December 5, 2019 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ Feature Indicates that this adds a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants