🔨 Refactor Deployment to use hooks

[MichaelDeBoey]

What kind of change does this PR introduce?

I've extracted @Saeris' changes to Deployment out of #1925.

What is the current behavior?

• Use mobx-react
• Use inject HOC

What is the new behavior?

• Use mobx-react-lite
• Use new useSignals & useStore hooks
• Refactor code to TS

What steps did you take to test this?

ZEIT Deploys

• Verify that deployment modal of ZEIT says you need to sign in
• Sign into ZEIT
• Deploy to ZEIT
• Make change to sandbox
• Deploy again, verify new URL

Netlify Deploys

• Deploy to Netlify
• Check that logs show
• Check that deployment is added
• Make change
• Deploy again, see if deployment is added
• Claim deployment, see if it works

Checklist

• Documentation N/A
• Testing
• Ready to be merged
• Added myself to contributors table N/A

[MichaelDeBoey]

@CompuIves @Saeris I've rebased onto master and pushed the suggested changes except for the destructuring.
When decided, I'll push those changes too. 🙂

[MichaelDeBoey]

Fixed some TypeScript errors (that weren't in #1986 yet) too

[MichaelDeBoey]

@CompuIves Since all checks pass, I think this one can be merged after a last review 🙂

[MichaelDeBoey]

@CompuIves I tested the Netlify build flow and that one works, except for the "show logs" button that's not showing.
I saw there was a problem with the WebSocket connection too, so maybe it has something to do with that? 🤔

WebSocket connection to 'wss://pr1969.build.csb.dev/socket/websocket?guardian_token=eyJhbGciOiJIUzUxMiIsInR5cCI6IkpXVCJ9.eyJhdWQiOiJDb2RlU2FuZGJveCIsImV4cCI6MTU2NTI1ODU3OCwiaWF0IjoxNTYyNjY2NTc4LCJpc3MiOiJDb2RlU2FuZGJveCIsImp0aSI6Ijk2YzhlOTYwLWQ0MzctNGZhMy1iOTljLTUzMDM0YWYwNGJmMCIsIm5iZiI6MTU2MjY2NjU3Nywic3ViIjoiVXNlcjpmZDE2ZmI3Mi1jNDllLTQ5NDktYjZlZi1mZTVjZWUwOWU0MjgiLCJ0eXAiOiJhY2Nlc3MifQ.xuUQwYx3ArzROl9wQQPlzohfrPr9uoFmn4apmu_-xjoCdfIxxkDJA3e2evpGR-2Im0q8qzjOeU5E8AUyUtGZJw&vsn=2.0.0'
failed: Error during WebSocket handshake: Unexpected response code: 200

I couldn't test the ZEIT build flow because of #2169

[CompuIves]

Thanks a lot @MichaelDeBoey, this is really good. So two things left for testing are:

1. View logs (why doesn't it show), seems like the webhook isn't related
2. ZEIT

I can do that now!

[MichaelDeBoey]

@CompuIves I won't have time until late this evening to take a look at it unfortunately, so be my guest if you have 🙂

[CompuIves]

After doing some testing on Netlify I also noticed that the status doesn't update. It should show this:

But it shows this:

I'm not sure if this is related to me testing on localhost? cc @SaraVieira

[CompuIves]

Oh wait now it suddenly shows "Building..." but much later, maybe an observability issue?

[CompuIves]

An observer was missing.

[MichaelDeBoey]

I just figured out I always need the observer when I use the useStore hook, so will take that in mind too from now on. 🙂