Skip to content

Conversation

@MichaelDeBoey
Copy link
Contributor

What kind of change does this PR introduce?
I've extracted @Saeris' changes to SSEDownNotice out of #1925.

What is the current behavior?

  • Use mobx-react
  • Use inject HOC

What is the new behavior?

  • Use mobx-react-lite
  • Use new useStore hook

Checklist:

  • Documentation N/A
  • Tests
  • Ready to be merged
  • Added myself to contributors table N/A


const ConnectionNotice = ({ store }) => {
export const SSEDownNotice = observer(() => {
const store = useStore();
Copy link
Contributor Author

@MichaelDeBoey MichaelDeBoey May 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Saeris I think you should destructur store just like you did in the other files

Suggested change
const store = useStore();
const {
editor: { currentSandbox: { template } },
server: { status },
} = useStore();

@CompuIves CompuIves merged commit 77d4415 into codesandbox:master May 27, 2019
@MichaelDeBoey MichaelDeBoey deleted the refactor-SSEDownNotice branch May 27, 2019 18:05
@MichaelDeBoey MichaelDeBoey mentioned this pull request May 28, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants