Skip to content

Add useInterval Hook, Refactor Live to use useInterval #1964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 11 commits into from
Closed

Add useInterval Hook, Refactor Live to use useInterval #1964

wants to merge 11 commits into from

Conversation

@MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented May 22, 2019 •
edited
Loading

What kind of change does this PR introduce?
I've extracted @Saeris' changes to Live out of #1925.

Added a useInterval Hook (demo here: https://codesandbox.io/s/sessiontimer-useinterval-hook-demo-0l6jq)
Refactored Live workspace item and it's dependents to use hooks.

What is the current behavior?

  • Class components

What is the new behavior?

  • Refactor to functional components
  • Created useInterval hook
  • Use useInterval hook in Live
  • Refactor code to TS

Checklist:

  • Documentation N/A
  • Tests
  • Ready to be merged
  • Added myself to contributors table N/A

@MichaelDeBoey MichaelDeBoey changed the title Refactor sandbox live Add useInterval Hook, Refactor Live to use useInterval May 22, 2019
@MichaelDeBoey MichaelDeBoey force-pushed the refactor-sandbox-live branch from cd2bf1b to b9e1044 Compare May 22, 2019 23:42
MichaelDeBoey
MichaelDeBoey commented May 22, 2019
View reviewed changes
@MichaelDeBoey MichaelDeBoey force-pushed the refactor-sandbox-live branch from b9e1044 to fe832ce Compare May 22, 2019 23:47
@MichaelDeBoey MichaelDeBoey mentioned this pull request May 23, 2019
Closed
@MichaelDeBoey MichaelDeBoey force-pushed the refactor-sandbox-live branch 3 times, most recently from bdfc425 to 372ffcd Compare May 30, 2019 13:29
@MichaelDeBoey MichaelDeBoey marked this pull request as ready for review May 30, 2019 13:30
@MichaelDeBoey MichaelDeBoey force-pushed the refactor-sandbox-live branch 2 times, most recently from 4b69f85 to 2a3c313 Compare June 4, 2019 23:45
@lbogdan lbogdan temporarily deployed to pr1964 June 5, 2019 00:02 Inactive
SaraVieira
SaraVieira reviewed Jun 6, 2019
View reviewed changes
packages/app/src/app/pages/Sandbox/Editor/Workspace/items/Live/LiveButton/elements.ts
`;

interface ButtonProps extends HTMLButtonElement {
disable?: boolean;
Copy link
Contributor

@SaraVieira SaraVieira Jun 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this disable and not disabled?

Copy link
Contributor

@Saeris Saeris Jun 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's what we had on the button props previously. Feel free to change.

@MichaelDeBoey MichaelDeBoey mentioned this pull request Jun 11, 2019
Merged
@MichaelDeBoey MichaelDeBoey force-pushed the refactor-sandbox-live branch from 2a3c313 to 72c637a Compare June 24, 2019 11:50
@lbogdan lbogdan temporarily deployed to pr1964 June 24, 2019 12:02 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the refactor-sandbox-live branch from c297986 to ec7ec48 Compare June 25, 2019 23:12
@lbogdan lbogdan temporarily deployed to pr1964 June 25, 2019 23:26 Inactive
@lbogdan lbogdan temporarily deployed to pr1964 June 25, 2019 23:45 Inactive
@lbogdan lbogdan temporarily deployed to pr1964 June 25, 2019 23:58 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the refactor-sandbox-live branch from da7f8c0 to 8790a29 Compare July 2, 2019 18:55
@lbogdan lbogdan temporarily deployed to pr1964 July 2, 2019 19:05 Inactive
@MichaelDeBoey
Copy link
Contributor Author

MichaelDeBoey commented Jul 2, 2019

@SaraVieira Since all checks pass, I think this one can be merged after a last review 🙂

@MichaelDeBoey MichaelDeBoey force-pushed the refactor-sandbox-live branch from 8790a29 to a8e6be2 Compare July 13, 2019 13:34
@lbogdan lbogdan temporarily deployed to pr1964 July 13, 2019 13:47 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the refactor-sandbox-live branch from a8e6be2 to f4959e6 Compare July 14, 2019 15:27
@CompuIves
Copy link
Member

CompuIves commented Jul 15, 2019

I'm going to test this one by:

  1. Creating a live session
  2. Test if all options still work and respond
  3. Join with another account
  4. Check if all options sync between two
  5. Hover over button and check if animation still shows
  6. Check if follow still works
  7. Check if UI updates if users leave/join

@MichaelDeBoey
Copy link
Contributor Author

MichaelDeBoey commented Jul 15, 2019

@CompuIves Will rebase to fix file conflicts later today 🙂

@MichaelDeBoey MichaelDeBoey force-pushed the refactor-sandbox-live branch from f4959e6 to 3ea0ca2 Compare July 17, 2019 00:15
@lbogdan lbogdan temporarily deployed to pr1964 July 17, 2019 00:22 Inactive
@lbogdan lbogdan temporarily deployed to pr1964 July 17, 2019 00:35 Inactive
@lbogdan lbogdan temporarily deployed to pr1964 July 17, 2019 00:44 Inactive
@lbogdan lbogdan temporarily deployed to pr1964 July 17, 2019 00:54 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the refactor-sandbox-live branch from dd41b70 to 9ce49aa Compare July 17, 2019 00:56
@lbogdan lbogdan temporarily deployed to pr1964 July 17, 2019 01:03 Inactive
@MichaelDeBoey
Copy link
Contributor Author

MichaelDeBoey commented Jul 17, 2019

@CompuIves All green again, only needs testing now 🙂

@MichaelDeBoey MichaelDeBoey force-pushed the refactor-sandbox-live branch from 9ce49aa to bc9664d Compare July 17, 2019 20:17
@lbogdan lbogdan temporarily deployed to pr1964 July 17, 2019 20:40 Inactive
@MichaelDeBoey MichaelDeBoey force-pushed the refactor-sandbox-live branch from bc9664d to c7ec652 Compare July 18, 2019 18:45
@MichaelDeBoey
Copy link
Contributor Author

MichaelDeBoey commented Jul 23, 2019

Ping @CompuIves

@MichaelDeBoey
Copy link
Contributor Author

MichaelDeBoey commented Sep 25, 2019

Closed this for the same reasons #1925 is closed

@MichaelDeBoey MichaelDeBoey deleted the refactor-sandbox-live branch September 25, 2019 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@SaraVieira SaraVieira SaraVieira left review comments

@Saeris Saeris Saeris left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🔨 Refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MichaelDeBoey @CompuIves @SaraVieira @Saeris @lbogdan