Refactor Advertisement to use useScript #1962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelDeBoey
force-pushed
the
refactor-advertisement
branch
from
f3a2047 to
4c4d849
Compare
MichaelDeBoey
commented
May 22, 2019
packages/app/src/app/pages/Sandbox/Editor/Workspace/Advertisement/index.ts
Show resolved
Hide resolved
MichaelDeBoey
force-pushed
the
refactor-advertisement
branch
from
4c4d849 to
1c7df61
Compare
MichaelDeBoey
commented
May 22, 2019
Closed
Removed unused container styles and reorganized code to follow updated coding conventions (to be documented at a later date). Added a new useScript hook (based on https://usehooks.com/useScript) and a hooks directory.
MichaelDeBoey
force-pushed
the
refactor-advertisement
branch
from
1c7df61 to
9353283
Compare
Contributor
Author
|
@CompuIves @Saeris Came across Maybe we should use this one (will add a dependency tho) or copy it over, since that's a more modern way of this hook and is |
Member
|
This is nice!! I'll merge this in now, thank you!
Let's evaluate it when we are going to support suspense. I want to keep it as simple as possible now. |
batiskafff
pushed a commit
to batiskafff/codesandbox-client
that referenced
this pull request
Jun 19, 2019
* 🔨 Add useScript Hook, Refactor Advertisement to use useScript Removed unused container styles and reorganized code to follow updated coding conventions (to be documented at a later date). Added a new useScript hook (based on https://usehooks.com/useScript) and a hooks directory. * Resolve discussions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
I've extracted @Saeris' changes to
Advertisementout of #1925.What is the current behavior?
CodeFundWhat is the new behavior?
CodeFundcomponent toAdvertisementuseScripthookuseScripthook inAdvertisementChecklist: