Make more efficient query #1958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that I blind coded this, so definitely check out in the preview if it works. reference: https://www.algolia.com/doc/api-reference/api-methods/get-objects/?language=javascript I also changed the require out for the way smaller `algoliasearch/lite`
Haroenv
reviewed
May 22, 2019
| index.search({ query: dependency, hitsPerPage: 1 }, (err, { hits }) => { | ||
| const versions = Object.keys(hits[0].versions).sort((a, b) => { | ||
| index.getObject(dependency, ['versions']).then(({ versions: hits }) => { | ||
| const versions = Object.keys(hits).sort((a, b) => { |
Contributor
There was a problem hiding this comment.
I'd keep calling this versions though, since hits is a list of packages usually
Contributor
There was a problem hiding this comment.
oh I see the problem now, the variable was declared twice
Contributor
Author
There was a problem hiding this comment.
The names clash, that's why I renamed it.
Im gonna rename to results, is that a better name?
Contributor
There was a problem hiding this comment.
index.getObject(dependency, ['versions']).then(result =>
const versions = Object.keys(result.versions).sort((a, b) => {
This could work too
This was referenced Jan 12, 2022
This was referenced Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finishing of #1954
cc @Haroenv