🔨 Hooks Refactor #1925
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| export { useInterval } from './useInterval'; | ||
| export { useScript } from './useScript'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| // Based on https://overreacted.io/making-setinterval-declarative-with-react-hooks/ | ||
| import { useEffect, useRef } from 'react'; | ||
|
|
||
| export const useInterval = (callback = () => {}, delay: number) => { | ||
| const savedCallback: { current: any } = useRef(); | ||
Saeris marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| useEffect(() => { | ||
| savedCallback.current = callback; | ||
| }, [callback]); | ||
|
|
||
| useEffect(() => { | ||
| function tick() { | ||
|
Contributor
There was a problem hiding this comment. This can be an arrow function const tick = () => savedCallback.current(); |
||
| savedCallback.current(); | ||
| } | ||
| if (delay !== null) { | ||
| const id = setInterval(tick, delay); | ||
| return () => clearInterval(id); | ||
| } | ||
| return undefined; | ||
Saeris marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| }, [delay]); | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| // Based on https://usehooks.com/useScript/ | ||
| import { useState, useEffect } from 'react'; | ||
|
|
||
| const cachedScripts = []; | ||
|
|
||
| export const useScript = (src: string) => { | ||
| const [state, setState] = useState({ | ||
| loaded: false, | ||
| error: false, | ||
| }); | ||
|
|
||
| useEffect(() => { | ||
| if (cachedScripts.includes(src)) { | ||
| setState({ | ||
| loaded: true, | ||
| error: false, | ||
| }); | ||
| } else { | ||
| cachedScripts.push(src); | ||
|
|
||
| const script = document.createElement('script'); | ||
Saeris marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| script.src = src; | ||
| script.async = true; | ||
|
|
||
| const onScriptLoad = () => { | ||
| setState({ | ||
| loaded: true, | ||
| error: false, | ||
| }); | ||
| }; | ||
|
|
||
| const onScriptError = () => { | ||
| const index = cachedScripts.indexOf(src); | ||
|
|
||
| if (index >= 0) cachedScripts.splice(index, 1); | ||
Saeris marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| script.remove(); | ||
|
|
||
| setState({ | ||
| loaded: true, | ||
| error: true, | ||
| }); | ||
| }; | ||
|
|
||
| script.addEventListener('load', onScriptLoad); | ||
| script.addEventListener('error', onScriptError); | ||
|
|
||
| document.body.appendChild(script); | ||
|
|
||
| return () => { | ||
| script.removeEventListener('load', onScriptLoad); | ||
| script.removeEventListener('error', onScriptError); | ||
| }; | ||
Saeris marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
|
|
||
| return undefined; | ||
Saeris marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| }, [src]); | ||
|
|
||
| return [state.loaded, state.error]; | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| import React from 'react'; | ||
| import { useScript } from 'app/hooks'; | ||
| import { Container } from './elements'; | ||
|
|
||
| export const Advertisement = () => { | ||
| useScript(`https://codefund.app/properties/24/funder.js`); | ||
Saeris marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| return ( | ||
| <Container> | ||
| <div id="codefund" /> | ||
| </Container> | ||
| ); | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| import styled, { css } from 'styled-components'; | ||
|
|
||
| export const Container = styled.div` | ||
| ${({ theme }) => css` | ||
| color: ${theme.light | ||
| ? css`rgba(0, 0, 0, 0.8)` | ||
| : css`rgba(255, 255, 255, 0.8)`} !important; | ||
| `}; | ||
| `; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export { Advertisement } from './Advertisement'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,18 @@ | ||
| import React from 'react'; | ||
| import { observer } from 'mobx-react-lite'; | ||
| import { useStore } from 'app/store'; | ||
| import { Container } from './elements'; | ||
|
|
||
| export const ConnectionNotice = observer(() => { | ||
| const { connected } = useStore(); | ||
|
|
||
| return ( | ||
| !connected && ( | ||
| <Container> | ||
| You{"'"}re not connected to the internet. You can still edit, but you | ||
| cannot save. We recommend using the {"'"}Download{"'"} function to keep | ||
| your changes. | ||
| </Container> | ||
| ) | ||
| ); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| import styled, { css } from 'styled-components'; | ||
|
|
||
| export const Container = styled.div` | ||
| ${({ theme }) => css` | ||
| color: ${theme.red}; | ||
| background-color: ${theme.redBackground}; | ||
| padding: 1rem; | ||
| font-size: 0.75rem; | ||
| `} | ||
| `; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export { ConnectionNotice } from './ConnectionNotice'; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.