-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Expo support #1807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expo support #1807
Conversation
|
Can someone recommend a good way to test this? |
|
Wooow, this is awesome!! Thanks a lot @EvanBacon! We deployed the PR to here: http://pr1807.cs.lbogdan.tk/s/new. There you can also test if you can add expo modules. I'd be glad to help get this through! |
|
@CompuIves thanks for the deploy! The aliases seem to work as expected. It looks like there is a bug where // This works: `expo-asset/build/AssetRegistry.web.js`
import * as AssetRegistry from 'expo-asset/build/AssetRegistry.web'
// This doesn't, it resolves to: `expo-asset/build/AssetRegistry.js`
// which also exists but is being used for the native functionality
// essentially returning an empty object as it's looking for a React Native `NativeModule`.
import * as AssetRegistry from 'expo-asset/build/AssetRegistry' |
|
Ahh, I see! I pushed a fix to master, if you merge it should work (on staging at least). |
|
This works really well! Still some bugs that I can work out in the individual modules. One more thing that would be nice is the environment variable |
Fixes the issue with #1807
|
Given that |
|
That's great!! I'll merge this in tomorrow morning! Really cool to have Expo support soon in CodeSandbox, I've been meaning for a long time to look into it. Thank you so much for contributing this @EvanBacon! |
What kind of change does this PR introduce?
What is the current behavior?
fixes #1806
What is the new behavior?
You can now use a wide variety of Expo modules.
Checklist: