Add support for netlify.toml #1772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CompuIves
requested changes
Apr 16, 2019
Member
CompuIves
left a comment
CompuIves
left a comment
There was a problem hiding this comment.
Looks very good to me! Keep in mind that people also have invalid configs (invalid syntax, wrong values for keys, etc...). We need to make sure that we handle all those cases well.
I left a few comments, we should be able to merge this after adding them!
packages/app/src/app/pages/Sandbox/Editor/Workspace/items/Deployment/Netlify.js
Outdated
Show resolved
Hide resolved
packages/app/src/app/pages/Sandbox/Editor/Workspace/items/Deployment/Netlify.js
Show resolved
Hide resolved
SaraVieira
commented
Apr 17, 2019
| 'package.json': 'npm', | ||
| 'sandbox.config.json': 'codesandbox', | ||
| 'now.json': 'now', | ||
| 'netlify.toml': 'settings', |
Contributor
Author
|
|
CompuIves
reviewed
Apr 17, 2019
Member
|
Merci!! |
This was referenced Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for a config file for netlify deployments.