Set max size on drag resize handlers #1691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Whoops, pressed wrong button 😅. This is reaaally great, thanks for the contribution!! |
Contributor
Author
|
My pleasure, and thanks for the merge! 😁 |
This was referenced Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fix issue #639 where the terminal's height going way above the editor's height, resulting in issues with dragging.
What is the current behavior?
#639
Checklist:
Added
flexShrink: 0to the terminal. Necessary to ensure it drags naturally. Otherwise there's an issue where flex tries to allocate equal space to the preview and the terminal, resulting in a very jaggy experience