Sandbox name resonance between sidebar and header #1690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 2, 2019 02:27
Member
|
Great! Thanks a lot @samrith-s |
CompuIves
requested changes
Apr 1, 2019
Member
CompuIves
left a comment
CompuIves
left a comment
There was a problem hiding this comment.
Left a small comment, after that it's ready for merge!
| <CollectionInfo isLoggedIn={store.isLoggedIn} sandbox={sandbox} /> | ||
| <CollectionInfo | ||
| isLoggedIn={store.isLoggedIn} | ||
| sandbox={{ ...sandbox }} |
Member
There was a problem hiding this comment.
Could you leave a comment as to why you do this? Also, maybe sandbox.toJS() works too.
Contributor
Author
There was a problem hiding this comment.
Will check that out, and shall leave a comment too!
* Used MobX toJS function over spreading
Contributor
Author
|
@CompuIves done! Do have a look. |
Member
|
Great! Thank you a lot, really nice to have these contributions! Merging now. |
This was referenced Apr 4, 2019
This was referenced Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
CollectionInfoinHeader's render function.What kind of change does this PR introduce?
This issue fixes a bug and maintains resonance of the sandbox name between the sidebar and the header.
What is the current behavior?
#1680
Checklist:
The issue was
CollectionInfowas being passed a reference to a sub-sect of observablestore, fromHeader. But MobX states that for the observable to trigger a reaction, it needs to be called inrender.The quick fix is to pass a new reference of
sandboxtoCollectionInfo, rather than passing the observable.