Pull request for issue #12 #13
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![google-labs-jules[bot]](https://avatars.githubusercontent.com/in/842251?s=60&v=4){kind=small}
This commit introduces internationalization (i18n) support for the Spanish language (`es`).
Key changes include:
- **Astro Configuration**: Updated `astro.config.mjs` to define `en` (default) and `es` locales, enabling path-based routing (`/es/...`).
- **Content Restructuring**:
- Created Spanish versions of select MDX content files (homepage, example post, a job, a talk) with `.es.mdx` suffixes and placeholder Spanish translations in frontmatter and body.
- Created Spanish versions of YAML link files (`.es.yml`) with placeholder translations for labels.
- **Page Updates**:
- Modified `src/pages/writing/[...slug].astro` to use `getRelativeLocaleUrl` for locale-aware navigation, ensuring the "Back to writing" link functions correctly in both languages.
- **Verification**:
- English content will be served from the root (`/`).
- Spanish content will be served from the `/es/` path.
- Content fetching via `getEntry` and `getCollection` is expected to serve the correct language versions based on Astro's i18n capabilities.
This provides the foundational structure for Spanish content. Further work would involve translating all content and localizing global constants (e.g., author details, default SEO metadata in `src/lib/constants.ts`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12