Skip to content

Conversation

a3ng7n
Copy link
Contributor

@a3ng7n a3ng7n commented Apr 18, 2025

(includes changes from #259 )

This makes clicking on a file in the directory structure insert the full file path to the include/exclude pattern. It does this by changing the output of _create_tree_structure from a single newline delimited string, to a list of those same lines, in tuples with the corresponding file path they represent.

The api interface that the user sees for ingest_query and format_node is kept the same; they both still output a tuple of three strings. But there's some added lifting to process_query to regenerate the context-aware directory tree, and use that within the html/js interaction functions. To eliminate this regeneration would mean either a very different architecture or changing the interfaces for ingest_query and format_node, both of which didn't seem like the right call.

keeping this as draft until if/when #259 gets merged

@filipchristiansen
Copy link
Contributor

@a3ng7n The tests are failing. Can you have a look at it?

@a3ng7n
Copy link
Contributor Author

a3ng7n commented Jun 21, 2025

Will do! Need a little to get back to a computer.

@filipchristiansen filipchristiansen changed the title Fix server directory structure input fix: insert full file path when selecting file in directory tree Jun 23, 2025
@filipchristiansen
Copy link
Contributor

Thanks for your efforts. However, I am closing as this has already been addressed in #295.

@a3ng7n
Copy link
Contributor Author

a3ng7n commented Jun 23, 2025

Thanks for your efforts. However, I am closing as this has already been addressed in #295.

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants